Fixed it wind direction
http://ar.geocities.com/barba_roar/ww/MarmolEn.zip
Versi?n en espa?ol Corregido la direcci?n del viento
http://ar.geocities.com/barba_roar/ww/MarmolEs.zip
Hugs
Fixed it wind direction
http://ar.geocities.com/barba_roar/ww/MarmolEn.zip
Versi?n en espa?ol Corregido la direcci?n del viento
http://ar.geocities.com/barba_roar/ww/MarmolEs.zip
Hugs
Since you asked, I have two suggestions;
1. post an image of what your skin looks like so visitors can determine whether it appeals to them or not. Thus they don’t have to download it, and overlay barba’s version, only to find they don’t like it.
2. rename your version to something like “Daves Marmol(english)”. Thus visitors can have both versions. It’s one thing to fix a bug in someone’s skin and keep it’s name, but you have gone beyond that and made changes that appeal to you (and mom :icon_smile: ) but may not appeal to the original author or that the original author may not wish to maintain. It’s the same approach I and others have done with Mike’s Splendid skin.
3. If you have used ideas and code from other skins posted here add comments in your code indicating where it was copied from or who’s idea it is based on thus acknowledging the work others have contributed to your creation.
Barba,
Your version of the skin had a bug that caused the scrolling ticker not to show correct sunrise and sunset data. It was off by a minute or two. I fixed the error. Other than that, you did a great job with the skin, especially with the wind direction arrows!
Attached is the fixed skin. Other than fixing the bug, it is the same one you posted on the forum.
http:://webpages.charter.net/david1970/MarmolEn.zip
i did not find the bug that you say.
please show me in which place of the program is.
I do not know if it is understood what I wrote
I not speak english
The sunrise and sunset times on the daily forecast screen and at the bottom of the current condition screen are correct. I compared that page to weather.com for several cities, and indeed they are corrent. However, the scrollng ticker is off by one minute, sometimes it is sunrise, sometimes it is sunset.
The problem is that you have [SUNRISE AMPM] and [SUNSET AMPM] in current.wtp and [DAILY SUNRISE AMPM] and [DAILY SUNSET AMPM] further down at current.wtp.
You need to change [SUNRISE AMPM] and [SUNSET AMPM]. Call it [DAILY SUNRISE AMPM] and [DAILY SUNSET AMPM].
I tried changing everything to [SUNRISE AMPM] and [SUNSET AMPM], but Weather Watcher refused to change the times for each day. I know that Ed will come along and say it doesn’t make a difference, but the program is very picky about this.
Once I changed everything to [DAILY SUNRISE AMPM] and [DAILY SUNSET AMPM], everything was working correctly.
David
Barba, I have the bug already fixed here
http://webpages.charter.net/david1970/MarmolEn.zip
I have made NO FURTHER CHANGES except to get rid of the bug.
Ed, I apologize if I offended anyone. I guess I got carried away. The only person whose code I copied was from your Stone Soup. I gave you credit on this message board, but didn’t realize it needed to be in the code too. Remember, I have done nothing like this before, so everything is really new to me. As for the code of the changing of the moon 180 degrees, that was all done by Barba, not me. Like you, I had no idea that the moon rotated 180 degrees in the southern hemisphere. The only difference between my last revision and Barba’s new version of Marmol is that he put a red O where I had “moon option”, so there is no need to make my own Marmol. I will make no further changes other than to fix bugs, like I did this morning.
I’m sorry if I caused any trouble.
David
You didn’t offend, we/I understand your enthusiasm, and in fact it is contagious and we have all benefited from it. I was just trying to help you finish up this project, tie up loose ends and to prepare you for the next one.
Barba,
I found a bug on the Daily Forecast Screen.
I fixed it.
When ever there was a night calm wind in the daily forecast, it would make a broken graphic.
Here is the correction that I made:
If this all sounds confusing, take my word for it, it has been fixed.
You can download the fixed skin at
http://webpages.charter.net/david1970/MarmolEn.zip
David
David, do you remember my saying to test all changes for 24 hrs before posting?
As for your fix wouldn’t testing one of the numerous WIND tags for the value 0 k/mh be easier, or adding a new wind graphic?
Ed,
I used the zipcode 23434 (my hometown), then went to the daily forecast screen. There were a couple of CALM nights, and above them were broken graphics. The rest of the arrows on the screen were correct. I went into daily.wtp and saw that he had the 3-letter, 2-letter, and 1-letter wind directions programmed in, but he did not have code for a 4-letter abbreviation (CALM) . I wrote that code, then went back into 23434. All arrows were correct, the CALM entries had no arrow and no broken graphic (like it should).
I wrote the code correctly. There may be other bugs in the skin, but the latest bug has been fixed. I apologize for not waiting 24 hours, but hopefully that is the last of the bugs. I know current.wtp has no bugs, as I already had tested that yesterday, the only change that Barba made was put a different options.jpg file in the images folder. I tested the hourly and detailed forecasts yesterday and they came back bug-free. The only change that Barba made was in the daily.wtp file, and that was with the wind arrows. All the nightly arrows are now working, as I have selected several cities, and viewed all wind directions.
Again, sorry for upsetting you.
David
I did not add a new wind graphic.
Barba already had one, but he just forgot to implement the code in daily.wtp to use it.
David
Fixed it
http://ar.geocities.com/barba_roar/ww/MarmolEn.zip
Versi?n en espa?ol Corregido
http://ar.geocities.com/barba_roar/ww/MarmolEs.zip
Hugs
http://img524.imageshack.us/img524/6421/barbasmarmolvx7.png
http://img524.imageshack.us/img524/6421/barbasmarmolvx7.4ecbb3058c.jpg
:laughing3: =D> :thumbleft: :hello1: :wav:
I like the version numbering, the only thing is you may have to add the time too. :lol:
The error still exists with your version.
Go to 23434 and to the daily forecast screen.
A couple of nights, the wind is going to be calm.
Your version of Marmol still shows broken graphics for those nights.
My version of Marmol is still working well with those nights
Download it at http://webpages.charter.net/david1970/MarmolEn.zip
THE ONLY DIFFERENCE BETWEEN MY VERSION AND YOURS IS THE BUG FIX. Everything else is the same.
David
An easier fix might be just reverting to the original Daily.wtp’s code. The image problem didn’t exist in it.
http://img413.imageshack.us/img413/9387/marmoldetailwindfixli9.th.jpg
Old skin on top, current skin on the bottom. Broken image on the bottom window, no broken image on the top window.
The difference between the current daily.wtp file and the original daily.wtp file is that the original daily.wtp gets the nightly wind direction wrong. The original daily.wtp file just repeats the afternoon’s wind direction.
For example
Let’s say weather.com says Friday afternoon wind direction will be South 5MPH, while Friday night’s wind direction will be Northeast 10MPH.
Here’s what the original daily.wtp would say:
Friday afternoon: South 5MPH
Friday night: South 10MPH
Here’s what the new daily.wtp would say:
Friday afternoon: South 5MPH
Friday night: Northeast 10MPH
See the problem, Ed?
David
After testing for 24 hours, I have improved the “mouseover” of the daily forecasts located at the bottom of the current conditions screen.
Before the today’s high becomes “N/A”, if you put your mouse on the first day, it will display the day and evening forecasts. After the high becomes “N/A”, the “mouseover” will display only the evening forecast for that first day. Just a matter of a simple “if” statement.
As for my version’s daily.wtp file, it’s working fine after over 24 hours of testing, and the daily forecast winds and arrows are the same as weather.com.
You can download the new version at http://webpages.charter.net/david1970/MarmolEn.zip
David
Fixed it
http://ar.geocities.com/barba_roar/ww/MarmolEn.zip
Versi?n en espa?ol Corregido
http://ar.geocities.com/barba_roar/ww/MarmolEs.zip
Hugs
The barometer bar graphic in the Fondo.jpg has clean, clear edges while the one in the animated Baro.gif has edges a little ragged near the top and bottom. Can this be changed or fixed?
Two approaches I thought might work;
BTW I like dlbryant’s color for the weather.com forecast link. Easier to see on the dark background. You might consider doing something similar.
The problem with the color of the forecast link is that it is in a dark background in the current conditions screen and the other screens (hourly, daily, detailed) it is a white background. But please don’t change the background of the current conditions screen, the dark brown background is too beautiful.
You may want to edit the style.css file in such a way that the color of the link is different in the current condition screen than it is in the other other screens (hourly, daily, and detailed).
David